Add WordAdsChartView #25165
Open
Add WordAdsChartView #25165
+829
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
kean
force-pushed
the
task/add-chart-view-ads-p2
branch
from
d12a20d to
463641f
Compare
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30606 | |
| Version | PR #25165 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 553795a | |
| Installation URL | 1dl7n6qqb217g |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30606 | |
| Version | PR #25165 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 553795a | |
| Installation URL | 3rnlo68sm7cfg |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
Contributor
|
A couple of issues on iPad:
|
Contributor
Author
Thanks for testing on iPad. I haven't yet. I fixed all three issues in the three latest commits and also removed the "Stats" title on iPad – it didn't look good. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes CMM-1132: Add WordAds revenue stats to Jetpack app.
This PR adds the main bar chart view for the WordAds tab. Since the WordAds API doesn't support custom date periods, it uses a simplified version of the chart (
SimpleBarChartView). Unlike the production version ofBarChartView, I made it use the newMetricTypeprotocol, so it's fully generalized.Testing instructions
I used one of the production accounts and made sure the data matches for all the available date periods and granularity options.
Screenshots & Recording
Screen.Recording.2026-01-23.at.4.20.56.PM.mov