Enable Dangermattic strings guardrail#22991
Open
mokagio wants to merge 1 commit into
Open
Conversation
Dangermattic 1.3.0 includes the Android strings API needed to flag in-place edits to existing translatable strings. Wire it into Danger while keeping release-process PRs skipped and allowing the explicit bypass label for intentional edits. --- Generated with the help of Codex, https://openai.com/codex Co-Authored-By: Codex GPT-5 <noreply@openai.com>
Contributor
|
|
Contributor
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Danger setup to use danger-dangermattic v1.3.x and turns on its Android strings “existing strings must not be modified” guardrail (with an escape hatch label).
Changes:
- Bump
danger-dangermatticfrom~> 1.2to~> 1.3(and update the lockfile accordingly). - Enable
android_strings_checker.check_existing_strings_not_modifiedinDangerfile, skipped when the PR has theAllow String Modificationslabel.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Gemfile.lock |
Locks danger-dangermattic to 1.3.0 and updates the danger dependency to match. |
Gemfile |
Updates the Bundler dependency constraint to danger-dangermattic ~> 1.3. |
Dangerfile |
Adds the Android strings guardrail check, with a label-based opt-out. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
danger-dangermatticto 1.3.0 and enables its Android strings guardrail.