Enable experimental pages in release builds (Phase 6)#22989
Open
nbradbury wants to merge 5 commits into
Open
Conversation
Covers the editor bridge's network fetch/insert/re-read flow and its error branch, which were previously untested. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The fetched page is a pass-through to the mocked mapper, so build it via a single @Suppress("DoNotMockDataClass") helper instead of mocking the ~29-field data class inline. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Lift the debug-only restriction so the new pages list can be opted into outside debug builds for broader soak testing. The flag still defaults off and routing is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #22989 +/- ##
=======================================
Coverage 37.46% 37.46%
=======================================
Files 2325 2325
Lines 125221 125221
Branches 17160 17160
=======================================
Hits 46913 46913
Misses 74502 74502
Partials 3806 3806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nbradbury
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simply exposes the
RS_PAGES_LISTexperimental flag in release builds so the new pages list can be opted into for all users. The flag still defaults off and routing is unchanged.Testing instructions