Remove Reader Announcement Card feature#22792
Merged
Conversation
The announcement card is outdated and no longer needed. This removes all related UI components, business logic, feature config, preferences, analytics tracking, and tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove unused imports, extra blank lines between import groups, and empty line before closing brace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
The default strings.xml had these removed but the translations were left behind, causing ExtraTranslation lint errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #22792 +/- ##
==========================================
- Coverage 37.34% 37.32% -0.03%
==========================================
Files 2327 2325 -2
Lines 124642 124579 -63
Branches 16893 16886 -7
==========================================
- Hits 46547 46493 -54
+ Misses 74358 74352 -6
+ Partials 3737 3734 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completely removes the outdated "New in Reader" announcement card feature. This card appeared above the Reader feed to highlight new Reader features (tags stream and reading preferences) and is no longer needed (it was first added in May 2024).
23 files changed, 19 insertions, 797 deletions. Note that many of those deletions were for unused string resources across language files. I needed to remove them to get lint to pass.
Testing instructions