Parallelize menu network requests by nbradbury · Pull Request #22562 · wordpress-mobile/WordPress-Android

nbradbury · 2026-02-05T15:01:40Z

Description

As part of CMM-1166, the fetchMenus and fetchMenuLocations requests now run in parallel using async/await. This should reduce initial load time since both requests happen simultaneously instead of sequentially.

Testing instructions

Go to My Site > Menus and verify the menu list loads as expected

Implements infinite scroll pagination for menu list, menu item list, and linkable items dropdown with page size of 20. Shows loading spinner when fetching more items. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Fix pagination not triggering after second page by properly tracking state changes in LaunchedEffect keys - Remove inaccurate menu item count from menu list - Remove unused fetchAllMenuItems function - Move Edit Items button to end of menu card, centered vertically - Fix detekt warnings: swallowed exceptions, unused imports, complexity - Extract MenuItemListContent and sibling helper functions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

The ExposedDropdownMenu doesn't support LazyColumn (SubcomposeLayout intrinsic measurement issue), causing crashes when opening the dropdown. This replaces it with a ModalBottomSheet which properly supports pagination with LazyColumn. Also restores PAGE_SIZE to 20 (was 5 for testing). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

This resource was left over after removing the menu item count feature. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Extract duplicate type selection label logic to helper function - Simplify parseErrorMessage by consolidating redundant cases - Consolidate findPreviousSiblingIndex/findNextSiblingIndex into single function Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Prevents race conditions when multiple pagination requests occur in rapid succession. Each pagination function now uses a mutex to ensure atomic read-check-update operations, preventing duplicate items or incorrect pagination state. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Ensure canLoadMore remains true when pagination fails, allowing users to retry after transient errors (network issues, timeouts, etc.). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Prevents stale data from overwriting state when user rapidly switches between menu item types. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Support all 22 protocols from wp_allowed_protocols(): http, https, ftp, ftps, mailto, news, irc, irc6, ircs, gopher, nntp, feed, telnet, mms, rtsp, sms, svn, tel, fax, xmpp, webcal, urn. Also adds support for anchor links (#section) and protocol-relative URLs (//). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Derive offset from UI state instead of cache variables to avoid race conditions between initial load and pagination - Set canLoadMore=true on initial load errors to allow retry Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Pre-compute parent-to-children mapping to reduce child lookup from O(n) to O(1) per item, improving overall complexity from O(n²) to O(n log n). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Use when expression to reduce return statements from 4 to 2. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Use async/await to fetch menus and locations concurrently, reducing initial load time. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

dangermattic · 2026-02-05T15:02:42Z

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2026-02-05T15:23:39Z

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22562-d342f01
	Build Number	`1484`
	Application ID	`com.jetpack.android.prealpha`
	Commit	`d342f01`
	Installation URL	4iuaecq01ds3g

Note: Google Login is not supported on these builds.

wpmobilebot · 2026-02-05T15:27:18Z

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22562-d342f01
	Build Number	`1484`
	Application ID	`org.wordpress.android.prealpha`
	Commit	`d342f01`
	Installation URL	0kk7qfi9kljsg

Note: Google Login is not supported on these builds.

codecov · 2026-02-05T15:35:26Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.28%. Comparing base (77b0da1) to head (d342f01).
⚠️ Report is 2 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...wordpress/android/ui/navmenus/NavMenusViewModel.kt	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #22562      +/-   ##
==========================================
- Coverage   38.28%   38.28%   -0.01%     
==========================================
  Files        2237     2237              
  Lines      111473   111476       +3     
  Branches    15579    15579              
==========================================
  Hits        42680    42680              
- Misses      65252    65255       +3     
  Partials     3541     3541

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-Android into issue/menus-parallel-requests Conflicts: WordPress/src/main/java/org/wordpress/android/ui/navmenus/NavMenusViewModel.kt

nbradbury · 2026-02-06T19:37:10Z

@claude

claude · 2026-02-06T19:37:32Z

Claude finished @nbradbury's task in 49s —— View job

Code Review Complete ✓

Read the changed file (NavMenusViewModel.kt)
Analyze the parallel request implementation
Review for correctness, error handling, and potential issues
Provide comprehensive feedback

Summary

The change successfully parallelizes the fetchMenus and fetchMenuLocations requests using Kotlin coroutines async/await, which should improve initial load time. The implementation is correct and follows good coroutine practices.

Review Feedback

✅ What's Good

Correct Use of coroutineScope: The function properly uses coroutineScope which ensures structured concurrency - if either request fails or is cancelled, both will be cleaned up properly.
Proper Async/Await Pattern: The implementation correctly:
- Creates two async coroutines to start both requests immediately
- Awaits both results sequentially
- This allows both network calls to run in parallel
No Breaking Changes: The function signature and return type remain the same, so this is a safe refactor with no downstream impact.
Error Handling Preserved: The existing error handling in the caller (loadMenusInternal) remains effective - exceptions will still propagate correctly through the coroutineScope.

📝 Observations

Performance Impact: This change should reduce load time from T(fetchMenus) + T(fetchMenuLocations) to max(T(fetchMenus), T(fetchMenuLocations)), which is a solid improvement.
Return Statement: The change from return when to just when (line 179) is correct since the coroutineScope lambda returns the last expression.
Import Additions: The two new imports (async, coroutineScope) are minimal and appropriate.

🎯 Verification

The change is focused and minimal (+8/-4 lines), which is ideal for this type of optimization. The implementation correctly handles:

Structured concurrency (both operations bound to same scope)
Cancellation (if parent scope cancels, both requests cancel)
Exception propagation (failure in either request surfaces properly)

Conclusion

This is a clean, well-implemented performance optimization. The parallel request pattern is used correctly, and the change achieves its stated goal without introducing any issues. ✅

sonarqubecloud · 2026-02-07T13:09:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adalpari

Nice improvement!

nbradbury and others added 15 commits February 5, 2026 06:12

Add pagination to navigation menus lists

99c142b

Implements infinite scroll pagination for menu list, menu item list, and linkable items dropdown with page size of 20. Shows loading spinner when fetching more items. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Remove unused menu_item_count plural resource

f49765a

This resource was left over after removing the menu item count feature. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Use whitelist for url validation

aab08fb

Fix pagination state reset on error

7d6c964

Ensure canLoadMore remains true when pagination fails, allowing users to retry after transient errors (network issues, timeouts, etc.). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Cancel linkable items loading job when menu item type changes

e8be827

Prevents stale data from overwriting state when user rapidly switches between menu item types. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Suppress LongMethod detekt warning

973124b

Optimize sortItemsHierarchically with pre-computed children map

a166ebd

Pre-compute parent-to-children mapping to reduce child lookup from O(n) to O(1) per item, improving overall complexity from O(n²) to O(n log n). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Refactor isValidLinkUrl to fix detekt ReturnCount violation

89dff5f

Use when expression to reduce return statements from 4 to 2. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Parallelize menu and location fetching in fetchMenuData

7f420b0

Use async/await to fetch menus and locations concurrently, reducing initial load time. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

nbradbury added the Menus label Feb 5, 2026

nbradbury changed the title ~~Add pagination and improvements to navigation menus~~ Parallelize menu network requests Feb 5, 2026

nbradbury and others added 5 commits February 6, 2026 10:24

Merge branch 'trunk' into issue/menus-parallel-requests

35713ff

Merge branch 'trunk' of https://github.com/wordpress-mobile/WordPress…

ec20d4c

…-Android into issue/menus-parallel-requests Conflicts: WordPress/src/main/java/org/wordpress/android/ui/navmenus/NavMenusViewModel.kt

Fixed minor warnings

84db76d

Restored Dangerfile from trunk

b692b80

Restored Dangerfile from trunk, p2

35ae941

nbradbury requested a review from adalpari February 6, 2026 20:22

nbradbury marked this pull request as ready for review February 6, 2026 20:22

Merge branch 'trunk' into issue/menus-parallel-requests

d342f01

nbradbury mentioned this pull request Feb 7, 2026

Hide navigation menus FAB on scroll #22575

Merged

5 tasks

adalpari approved these changes Feb 9, 2026

View reviewed changes

nbradbury merged commit bcdb13d into trunk Feb 9, 2026
24 checks passed

nbradbury deleted the issue/menus-parallel-requests branch February 9, 2026 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parallelize menu network requests#22562

Parallelize menu network requests#22562
nbradbury merged 21 commits intotrunkfrom
issue/menus-parallel-requests

nbradbury commented Feb 5, 2026 •

edited

Loading

Uh oh!

dangermattic commented Feb 5, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 5, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 5, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 5, 2026 •

edited

Loading

Uh oh!

nbradbury commented Feb 6, 2026

Uh oh!

claude bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Feb 7, 2026

Uh oh!

adalpari left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nbradbury commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

dangermattic commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nbradbury commented Feb 6, 2026

Uh oh!

claude bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Complete ✓

Summary

Review Feedback

✅ What's Good

📝 Observations

🎯 Verification

Conclusion

Uh oh!

sonarqubecloud bot commented Feb 7, 2026

Quality Gate passed

Uh oh!

adalpari left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nbradbury commented Feb 5, 2026 •

edited

Loading

dangermattic commented Feb 5, 2026 •

edited

Loading

wpmobilebot commented Feb 5, 2026 •

edited

Loading

wpmobilebot commented Feb 5, 2026 •

edited

Loading

codecov bot commented Feb 5, 2026 •

edited

Loading

claude bot commented Feb 6, 2026 •

edited

Loading