Closed
Conversation
This is to avoid local issues with Simulator clones.
mokagio
commented
Nov 27, 2025
Comment on lines
5
to
7
| echo "--- :pencil2: Breaking bundle resource path to verify test catches failures" | ||
| # Replace "Gutenberg" with "folder_that_does_not_exist" in the HTMLPreviewManager | ||
| sed -i.bak 's/forResource: "Gutenberg", withExtension: nil/forResource: "folder_that_does_not_exist", withExtension: nil/g' ios/Sources/GutenbergKit/Sources/Views/HTMLPreview/HTMLPreviewManager.swift |
Contributor
Author
There was a problem hiding this comment.
Since we can't inject values that would result in a crash and we can't test for crashes anyways when targeting iOS we hack the code to force a crash and test that the tests fail as expected.
mokagio
commented
Nov 27, 2025
.buildkite/commands/verify-xcframework-test-fails-with-missing-resources.sh
Outdated
Show resolved
Hide resolved
Closed
Contributor
Author
|
Closing in favor of #318 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo for building the package as an XCFramework, with CI bare bone integration tests.
What?
Why?
How?
Testing Instructions
Accessibility Testing Instructions
Screenshots or screencast