Fix checkbox interaction for indented (nested) task list items#1118
Open
Fix checkbox interaction for indented (nested) task list items#1118
Conversation
…item spans by nesting level in isChecked() so the line index aligns with direct children only, matching how getIndexOfProcessedLine() counts them. Without this, nested items shift the index and cause checkboxes to render the wrong state.
Select the innermost AztecTaskListSpan at the tap position instead of an arbitrary one, and compute the x-coordinate boundary based on nesting depth so taps on indented checkboxes are recognized.
The previous check rejected taps beyond a single leading margin width, preventing interaction with indented checkboxes. The handler now performs its own nesting-aware check, so the outer gate only needs to verify the editor is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Fix checkbox interaction for indented (nested) task list items.
Note
This PR can be tested with DayOne-Android via the companion PR here
Three issues were addressed:
Test Steps
Make sure strings will be translated:
strings.xmlas a part of the integration PR.