Remove @react-native-community/art in favor of react-native-svg for Expo support#64
Open
chiubaka wants to merge 4 commits intowonsikin:masterfrom
Open
Remove @react-native-community/art in favor of react-native-svg for Expo support#64chiubaka wants to merge 4 commits intowonsikin:masterfrom
chiubaka wants to merge 4 commits intowonsikin:masterfrom
Conversation
|
I just wonder why this is still not merged )) Thanks Daniel @chiubaka |
|
@wonsikin Any news? |
|
@wonsikin could you merge it please? |
|
@wonsikin Any reviews? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve #59 and resolve #56 without needing to eject from Expo, and relates to #49.
I made a few small changes to generate the barcode images with
react-native-svginstead of@react-native-community/art. Since Expo doesn't support@react-native-community/artwithout ejecting, this modification keeps this library compatible with the latest versions of Expo's managed workflows.