[FEAT] Optional maxWidth prop for barcode maximum width#58
Open
crherman7 wants to merge 1 commit intowonsikin:developfrom
Open
[FEAT] Optional maxWidth prop for barcode maximum width#58crherman7 wants to merge 1 commit intowonsikin:developfrom
crherman7 wants to merge 1 commit intowonsikin:developfrom
Conversation
crherman7
changed the title
Adds optional prop - maxWidth of the barcode and determines if the barcode width exceeds the maxWidth; if the maxWidth is exceeded it then calculates the barcode block width based uponn the encoded data length and maxWidth.
crherman7
force-pushed
the
feat/barcode_max_width
branch
from
4d523a6 to
c3fb028
Compare
crherman7
changed the title
|
@wonsikin is this something that could be looked at? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is no maximum width prop that would specify the maximum width of the barcode. There is a
widthprop but that specifies the width of each individual block in the barcode. With a use case of having dynamic values being shown as a barcode but a maximum width of a parent container the barcode would potentially overflow the parent container.Solution
Adds optional prop -
maxWidthof the barcode and determines if the barcode width exceeds themaxWidth; if the maxWidth is exceeded it then calculates the barcode block width based uponn the encoded data length and maxWidth.