fix: avoid loading legacy PdfView on Fabric path#1022
Open
hknakn wants to merge 1 commit into
Open
Conversation
|
Bump! Can we please merge in this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a New Architecture/Fabric runtime import issue by keeping the Fabric/native component as the default path and avoiding evaluation of the legacy fallback module during package import.
In Expo SDK 56 / RN 0.85, native codegen and
RNPDFPdfViewregistration work, butindex.jsstill eagerly imports the legacyPdfViewfallback. That can make the package fail during JS module initialization before Fabric renders.This change lazy-loads the legacy fallback only if that branch is actually reached. The default Fabric path is unchanged.
Related
Related to #942, #986, and the iOS Fabric work in #927. Also follows recent New Architecture/Fabric fixes in #1011 and #1012, and may overlap with #968.
cc @wonday @Prajwaltechversant @francoangulo @yfuks @mavrickdeveloper @huydosgtech @maribeiroleya
Testing
node --check index.jsCan this be merged and released as a patch version, e.g.
7.0.5?