Skip to content

Server names are unsafe strings #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfadex merged 1 commit into from
Oct 15, 2025
Merged

Server names are unsafe strings #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/OpenApi/Generate.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,18 @@ serverDeclarations server =
list
|> List.map
(\{ name, url, description } ->
let
safeName : String
safeName =
Common.toValueName name
in
{ moduleName = Common.Servers
, name = name
, name = safeName
, declaration =
url
|> stripTrailingSlash
|> Elm.string
|> Elm.declaration name
|> Elm.declaration safeName
|> (case description of
Nothing ->
identity
Expand Down Expand Up @@ -1774,7 +1779,7 @@ toConfigParamAnnotation options =

type ServerInfo
= SingleServer String
| MultipleServers (List { name : String, url : String, description : Maybe String })
| MultipleServers (List { name : Common.UnsafeName, url : String, description : Maybe String })


serverInfo : OpenApi.Config.Server -> CliMonad ServerInfo
Expand Down Expand Up @@ -1811,7 +1816,7 @@ serverInfo server =
Just d ->
d
in
{ name = name
{ name = Common.UnsafeName name
, url = OpenApi.Server.url value
, description = description
}
Expand All @@ -1823,7 +1828,7 @@ serverInfo server =
|> Dict.toList
|> List.map
(\( name, url ) ->
{ name = name
{ name = Common.UnsafeName name
, url = url
, description = Nothing
}
Expand Down