Skip to content

Use Dict.Extra.find for efficiency #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfadex merged 1 commit into from
Oct 5, 2025
Merged

Use Dict.Extra.find for efficiency #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion elm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"mdgriffith/elm-codegen": "5.2.0 <= v < 6.0.0",
"miniBill/elm-fast-dict": "1.2.0 <= v < 2.0.0",
"robinheghan/murmur3": "1.0.0 <= v < 2.0.0",
"turboMaCk/non-empty-list-alias": "1.4.0 <= v < 2.0.0",
"wolfadex/elm-open-api": "2.0.0 <= v < 3.0.0"
},
"test-dependencies": {
Expand Down
9 changes: 3 additions & 6 deletions src/OpenApi/Generate.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ import Gen.Url.Builder
import Json.Schema.Definitions
import JsonSchema.Generate
import List.Extra
import List.NonEmpty
import OpenApi
import OpenApi.Common.Internal
import OpenApi.Components
Expand Down Expand Up @@ -2342,7 +2341,7 @@ operationToTypesExpectAndResolver functionName operation =
)
getFirstSuccessResponse
|> CliMonad.andThen
(\( ( _, responseOrRef ), _ ) ->
(\( _, responseOrRef ) ->
let
errorResponses : Dict.Dict String (OpenApi.Reference.ReferenceOr OpenApi.Response.Response)
errorResponses =
Expand Down Expand Up @@ -2683,12 +2682,10 @@ isSuccessResponseStatus status =
String.startsWith "2" status || String.startsWith "3" status


getFirstSuccessResponse : Dict.Dict String (OpenApi.Reference.ReferenceOr OpenApi.Response.Response) -> Maybe (List.NonEmpty.NonEmpty ( String, OpenApi.Reference.ReferenceOr OpenApi.Response.Response ))
getFirstSuccessResponse : Dict.Dict String (OpenApi.Reference.ReferenceOr OpenApi.Response.Response) -> Maybe ( String, OpenApi.Reference.ReferenceOr OpenApi.Response.Response )
getFirstSuccessResponse responses =
responses
|> Dict.toList
|> List.filter (Tuple.first >> isSuccessResponseStatus)
|> List.Extra.uncons
|> Dict.Extra.find (\code _ -> isSuccessResponseStatus code)


getErrorResponses : Dict.Dict String (OpenApi.Reference.ReferenceOr OpenApi.Response.Response) -> Dict.Dict String (OpenApi.Reference.ReferenceOr OpenApi.Response.Response)
Expand Down