Skip to content

Improve error message for missing formats #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfadex merged 1 commit into from
Oct 5, 2025
Merged

Improve error message for missing formats #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 32 additions & 7 deletions src/CliMonad.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,13 @@ withFormat basicType maybeFormatName getter default =
Just formatName ->
CliMonad
(\{ formats } ->
let
basicTypeName : String
basicTypeName =
Common.basicTypeToString basicType
in
case
FastDict.get ( Common.basicTypeToString basicType, formatName ) formats
FastDict.get ( basicTypeName, formatName ) formats
of
Nothing ->
let
Expand Down Expand Up @@ -520,14 +525,34 @@ withFormat basicType maybeFormatName getter default =
emptyOutput

else
let
firstLine : String
firstLine =
"Don't know how to handle format \""
++ formatName
++ "\" for type "
++ Common.basicTypeToString basicType
++ ", treating as the corresponding basic type."

available : List String
available =
List.filterMap
(\( b, f ) ->
if b == basicTypeName then
Just f

else
Nothing
)
(FastDict.keys formats)

secondLine : String
secondLine =
" Available formats: " ++ String.join ", " available
in
{ emptyOutput
| warnings =
[ { message =
"Don't know how to handle format \""
++ formatName
++ "\" for type "
++ Common.basicTypeToString basicType
++ ", treating as the corresponding basic type."
[ { message = firstLine ++ "\n" ++ secondLine
, path = [ "format" ]
}
]
Expand Down