Split original ASN.1 code from asn.c into asn_orig.c#9920
Open
dgarske wants to merge 2 commits intowolfSSL:masterfrom
Open
Split original ASN.1 code from asn.c into asn_orig.c#9920dgarske wants to merge 2 commits intowolfSSL:masterfrom
dgarske wants to merge 2 commits intowolfSSL:masterfrom
Conversation
Move non-template (WOLFSSL_ASN_ORIGINAL) code into asn_orig.c and include from asn.c.
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the non-template ASN.1 implementation into a separate asn_orig.c file and ensures it’s included in distributed source archives.
Changes:
- Adds the new
wolfcrypt/src/asn_orig.cfile to Automake’sEXTRA_DISTso it’s shipped in release tarballs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Add settings.h include before the compile guard in asn_orig.c so WOLFSSL_IGNORE_FILE_WARN is available when compiled separately. Add -Wno-pedantic for asn_orig.c in async examples Makefile to suppress empty translation unit warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move non-template (
WOLFSSL_ASN_ORIGINAL) code intoasn_orig.cand include fromasn.c.