Fix macro protection in ARM SP asm#9772
Closed
bigbrett wants to merge 1 commit intowolfSSL:masterfrom
Closed
Conversation
…sed function warning when used with RSA_LOW_MEM
Contributor
Author
|
@SparkiDev I believe the changes proposed in this PR actually need to be fixed in your ruby scripts. Therefore closing this PR and assigning you as an FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes macro protection for
sp_*_cond_add_*in the ARM SP asm code to prevent unused function warning when used withRSA_LOW_MEM.Before this PR, using RSA_LOW_MEM with WOLFSSL_SP_CORTEX_M_ASM would result in the following compiler warning:
Saw it needs to be fixed in some of the other ARM asm as well.