Split out code form ssl.c and pk.c#9723
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Feb 6, 2026
Merged
Conversation
Move EC and RSA code out of pk.c into separate file. Move out of ssl.c into separate files: - Certificate APIs - CRL/OCSP APIs - Public Key APIs - ECH Internal Certificate Manager APIs pulled out into ssl_certman.c. d2i and i2d WOLFSSL_EVP_PKEY APIs pulled out into evp_pk.c. Fix formatting.
SparkiDev
force-pushed
the
ssl_split_cert
branch
from
9ee4af8 to
be45847
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Jenkins retest this please - CI issue PRB-Master-Job |
Contributor
|
Jenkins retest this please. Jenkins master job history lost. |
dgarske
approved these changes
Feb 5, 2026
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Let's please get this cleanup merged! Thank you Sean
Contributor
|
retest this please |
douzzer
approved these changes
Feb 6, 2026
douzzer
added a commit
to douzzer/wolfssl
that referenced
this pull request
Feb 6, 2026
…defect introduced in wolfSSL#9723); wolfcrypt/test/test.c: fix error-path memory leaks in srtpkdf_test(), and properly gate out incompatible SRTP_KDF_LONG_KEY test on old FIPS (defect introduced in wolfSSL#9733); .wolfssl_known_macro_extras: get into lexical order and remove unneeded WC_RSA_DIRECT.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move EC and RSA code out of pk.c into separate file.
Move out of ssl.c into separate files:
Internal Certificate Manager APIs pulled out into ssl_certman.c. d2i and i2d WOLFSSL_EVP_PKEY APIs pulled out into evp_pk.c.
Fix formatting.
Testing
Regression tested.
Checklist