Skip to content

zero-initialize DecodedCert immediately after allocation in wolfSSL_CertManagerCABufferType#10437

Merged
SparkiDev merged 1 commit into
wolfSSL:masterfrom
gasbytes:CertManagerLoadCABufferType_MoveXMemset
May 12, 2026
Merged

zero-initialize DecodedCert immediately after allocation in wolfSSL_CertManagerCABufferType#10437
SparkiDev merged 1 commit into
wolfSSL:masterfrom
gasbytes:CertManagerLoadCABufferType_MoveXMemset

Conversation

@gasbytes
Copy link
Copy Markdown
Contributor

@gasbytes gasbytes commented May 8, 2026

Description

zero-initialize DecodedCert immediately after allocation in wolfSSL_CertManagerCABufferType to prevent cleanup on an uninitialized struct on the pem error path.

Fixes zd#21777

Testing

Against reproducer from zd#21777 with:
./configure --enable-debug --enable-pkcs7=no --enable-opensslall=no --enable-opensslextra=no --enable-shared --enable-static
as configuration.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gasbytes gasbytes self-assigned this May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

MemBrowse Memory Report

No memory changes detected for:

@gasbytes gasbytes marked this pull request as ready for review May 8, 2026 14:29
@gasbytes
Copy link
Copy Markdown
Contributor Author

gasbytes commented May 8, 2026

Jenkins retest this please

@gasbytes
Copy link
Copy Markdown
Contributor Author

gasbytes commented May 9, 2026

Jenkins retest this please (lost logs)

@gasbytes gasbytes force-pushed the CertManagerLoadCABufferType_MoveXMemset branch from 5c4922c to 66bc5ea Compare May 9, 2026 16:46
@gasbytes
Copy link
Copy Markdown
Contributor Author

Jenkins retest this please (logs lost)

wolfssl_certmanagerloadcabuffertype to prevent cleanup on an
uninitialized struct on the pem error path.
@gasbytes gasbytes force-pushed the CertManagerLoadCABufferType_MoveXMemset branch from 66bc5ea to 54bb2c2 Compare May 11, 2026 18:12
@gasbytes gasbytes assigned wolfSSL-Bot and unassigned gasbytes May 11, 2026
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10437

Scan targets checked: wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

@SparkiDev SparkiDev merged commit f436fb8 into wolfSSL:master May 12, 2026
443 of 444 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants