Test Fix: flakiness fix (hopefully) for ocsp-stapling scripts#10049
Open
sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
Open
Test Fix: flakiness fix (hopefully) for ocsp-stapling scripts#10049sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces flakiness in OCSP stapling test scripts by replacing fixed sleeps with readiness probes (port-open checks and ready-file creation/waits), including improved handling for UDP-ready-file creation.
Changes:
- Add
wait_for_port()polling to ensure OpenSSL OCSP responders have actually opened their listening ports before continuing. - Replace several fixed
sleepdelays withwait_for_readyFile(and add missing ready-file cleanup in a few DTLS cases). - Create the server “ready file” during UDP accept paths to support readiness signaling for DTLS runs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
wolfssl/test.h |
Create ready-file during UDP accept path; fix typo in comment. |
scripts/ocsp-stapling_tls13multi.test |
Add port readiness probing for multiple OCSP responders; use ready-file wait instead of sleeps. |
scripts/ocsp-stapling2.test |
Add port readiness probing; increase OpenSSL server wait timeout; use ready-file wait instead of sleeps. |
scripts/ocsp-stapling.test |
Add port readiness probing; increase OpenSSL server wait timeout; remove sleeps in favor of ready-file waits. |
scripts/ocsp-stapling-with-wolfssl-responder.test |
Replace sleeps with wait_for_readyFile in more places. |
scripts/ocsp-stapling-with-ca-as-responder.test |
Add port readiness probing for OpenSSL OCSP responder startup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scripts/ocsp-stapling* tends to fail randomly. This seems to be either failures to get a port or (more probably) the ready file is not written/checked.
Added probing to test if port has been opened by process.
Added missing readyfile checks.
Added ready file creation when using udp.
Testing
Ran the ocsp-stapling tests. They seem to work fine but the issue itself is hard to reproduce. We will see if this fixes it.
Checklist