Guard old non-ctx ML-DSA API by default#10047
Draft
Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Draft
Guard old non-ctx ML-DSA API by default#10047Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR guards the legacy non-context ML-DSA API behind
WOLFSSL_DILITHIUM_NO_CTXand makes context-aware APIs the default path.What changed
no-ctxas a valid--enable-dilithiumoption in configure.ac to explicitly enable legacy no-context APIs.#ifdef WOLFSSL_DILITHIUM_NO_CTXinwolfssl/wolfcrypt/dilithium.handwolfcrypt/src/dilithium.c.WOLFSSL_DILITHIUM_NO_CTXwhenWOLFSSL_DILITHIUM_FIPS204_DRAFTis enabled.ctx=NULL, ctxLen=0):WOLFSSL_DILITHIUM_NO_CTX.test_wc_dilithium_sign_ctx_kats,test_wc_dilithium_verify_ctx_kats).