Skip to content

Add github workflow to check for wolfboot regressions#10029

Open
danielinux wants to merge 4 commits intowolfSSL:masterfrom
danielinux:wolfboot-integration-tests
Open

Add github workflow to check for wolfboot regressions#10029
danielinux wants to merge 4 commits intowolfSSL:masterfrom
danielinux:wolfboot-integration-tests

Conversation

@danielinux
Copy link
Member

Description

A selection of tests to intercept any changes that would break wolfboot.

Copilot AI review requested due to automatic review settings March 20, 2026 15:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions workflow to run a curated set of wolfBoot integration checks against the wolfSSL code under test, aiming to catch regressions early.

Changes:

  • Introduces a new wolfboot-integration.yml workflow with multiple jobs (keytools, Renode configs, host smoke).
  • Clones wolfBoot and links the PR’s wolfSSL workspace into wolfBoot for integration validation.
  • Uploads Renode execution logs as build artifacts for debugging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 20, 2026 17:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danielinux danielinux marked this pull request as ready for review March 21, 2026 08:30
@danielinux danielinux requested review from Copilot and wolfSSL-Bot and removed request for wolfSSL-Bot March 21, 2026 08:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +233 to +240
make test-lib SIGN=ED25519 HASH=SHA256
success_output=$(./test-lib test_v1_signed.bin 2>&1)
success_status=$?
printf '%s\n' "$success_output"
if [ "$success_status" -ne 0 ]; then
echo "Expected success, but test-lib failed"
exit 1
fi
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With set -e enabled, success_output=$(./test-lib …) will cause the step to exit immediately if ./test-lib returns non-zero, so the subsequent status check and the more descriptive error output won’t run. If you want the extra diagnostics on unexpected failure, wrap this invocation the same way you do later (set +e / capture / set -e).

Copilot uses AI. Check for mistakes.
@dgarske
Copy link
Contributor

dgarske commented Mar 21, 2026

Jenkins retest this please. History lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants