Draft
Conversation
In theory these tests will find more non-blocking issues.
The test failures revealed that only echoserver (-N flag) and wolfsftp (-N flag) properly support non-blocking I/O handling. wolfscp and wolfsshd do not have the retry logic to handle WS_WANT_READ/WS_WANT_WRITE returns from TEST_BLOCK. Changes: - scp.test: Revert to skip (exit 77) when TEST_BLOCK is detected since wolfscp doesn't support non-blocking mode - network-contention-test.yml: Remove SCP tests, fix SFTP tests to use expect instead of echo pipe (which was causing "fgets error") - Remove paramiko-contention-test.yml: wolfsshd doesn't support TEST_BLOCK (hangs during SSH handshake) The remaining SFTP contention tests properly exercise the non-blocking code paths using echoserver -N and wolfsftp -N. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In theory these tests will find more non-blocking issues.