DoAsn1Key now fails when WOLFSSH_NO_RSA is defined#808
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Jun 11, 2025
Merged
DoAsn1Key now fails when WOLFSSH_NO_RSA is defined#808ejohnstown merged 1 commit intowolfSSL:masterfrom
ejohnstown merged 1 commit intowolfSSL:masterfrom
Conversation
ejohnstown
requested changes
Jun 11, 2025
f524634 to
429cf16
Compare
ejohnstown
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
ssh.cto fix compile-time error when RSA is disabled.Without this fix, this line in
DoAsn1Key():fails to compile as there's no
.rsa.keymember property:With this PR, the code compiles and exits
IdentifyAsn1Key()with error codeWS_RSA_Eand a message when debugging is enabled.