FATFS improvements, test and Linux example#787
Merged
Conversation
FATFS compiling is currently broken due to several reasons. This fixes: * Bad parameter count for `WRENAME` * Missing `WFFLUSH` define * `WOLFSSH_STOREHANDLE` required for `WOLFSSH_FATFS` to work * Conflict when `NO_FILESYSTEM` is defined for wolfSSL and `WOLFSSH_FATFS` is defined by wolfSSH * Function called that can't be used with `WOLFSSH_FATFS` * Functions defined but not used with `WOLFSSH_FATFS` * Function parameters defined but not used
This allows a file on the Linux filesystem to be used as a FATFS file. It also fixes a bug in `port.h` when opening file on a FATFS filesystem.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Can one of the admins verify this patch? |
This adds a GitHub Action workflow to test the FATFS support for the wolfsftp client. The workflow: - Installs dependencies - Clones and builds wolfSSL with appropriate flags - Compiles the FATFS library - Configures and builds wolfSSH with FATFS support - Creates a test file - Sets up an SSH server - Uses the wolfsftp client to transfer a test file - Verifies the file in the FATFS image Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com> Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
devin-ai-integration
bot
force-pushed
the
devin/1740666408-add-fatfs-test-action
branch
from
13d866a to
da01cea
Compare
LinuxJedi
changed the title
dgarske
requested changes
Feb 27, 2025
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
dgarske
requested changes
Feb 27, 2025
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Member
|
(aside) @dgarske the Devin session appears to have broken down to the point where it can no long push to this PR. I can make any additional required changes. |
JacobBarthelmeh
requested changes
Mar 5, 2025
LinuxJedi
force-pushed
the
devin/1740666408-add-fatfs-test-action
branch
from
1b9f3c7 to
dfc0f72
Compare
JacobBarthelmeh
previously approved these changes
Mar 6, 2025
Contributor
|
(aside) Ok to test, Jenkins |
dgarske
requested changes
Mar 6, 2025
dgarske
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compiling issues with FATFS, a couple of bugs with it and adds an example of how to compile wolfSSH with a wolfSFTP client using FATFS in Linux.
Devin added to this PR to add a GitHub Action workflow to test FATFS support for the wolfsftp client. It is related to PR #786 which fixes compiling issues with FATFS, a couple of bugs with it, and adds an example of how to compile wolfSSH with a wolfSFTP client using FATFS in Linux.
The GitHub Action workflow:
Link to Devin run: https://app.devin.ai/sessions/b8ce6600638040d996121c54a3a3e139
Requested by: andrew@wolfssl.com