Add GitHub Actions workflow for g++ and clang compilation#778
Add GitHub Actions workflow for g++ and clang compilation#778devin-ai-integration[bot] wants to merge 24 commits intomasterfrom
Conversation
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Can one of the admins verify this patch? |
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
|
This will need a squash when merging, but I think it covers what I asked for. |
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
This is great in that it adds testing with different compilers. I think it misses what the pull request title suggests though, and does not test with something along the lines of ./configure --enable-all CC=g++. Forcing the use of g++ when compiling wolfSSH.
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
|
Closing this. Devin misunderstood the review comment as being too specific, spiralled and it is going to be a do-over judging by the current state of the test. |
This PR adds a GitHub Actions workflow to test compilation using g++ and clang compilers.
Link to Devin run: https://app.devin.ai/sessions/ba369f2814354098a9ad07160875a337
Requested by: andrew@wolfssl.com