Skip to content

Conversation

@danielinux
Copy link
Member

No description provided.

@danielinux danielinux requested review from Copilot and philljj February 9, 2026 19:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes FIFO tail alignment behavior when the FIFO is empty (tail == head), preventing state from being mutated during empty reads and adding regression coverage around odd-sized datagrams and UDP receive ordering.

Changes:

  • Prevent fifo_align_tail() from adjusting tail when the FIFO is empty.
  • Add FIFO unit tests for empty/un-aligned tail behavior and odd-sized push/pop draining.
  • Add an integration test covering UDP recv/recvfrom sequencing to catch alignment regressions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/wolfip.c Avoids mutating FIFO tail alignment when tail == head (empty FIFO).
src/test/unit/unit.c Adds regression tests to ensure FIFO empty operations don’t realign tail and UDP reads remain correct across odd payload sizes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@philljj philljj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@philljj philljj merged commit 4e6843e into wolfSSL:master Feb 9, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants