More various fixes (casting, missing checks etc...)#20
Open
gasbytes wants to merge 10 commits intowolfSSL:masterfrom
Open
More various fixes (casting, missing checks etc...)#20gasbytes wants to merge 10 commits intowolfSSL:masterfrom
gasbytes wants to merge 10 commits intowolfSSL:masterfrom
Conversation
- validate TCP header langth against IP payload and see if it actually fits or not, return on error
of uint16_t pointer casts)
…mbers, preventing unsigned wraparound in bytes_in_flight
…cksum update - add tcp_seq_inc() helper for wrap-safe sequence number arithmetic, replacing bare ee32(tcp->seq) + 1 in all five call sites - fold carry in ICMP echo reply checksum update to avoid uint16_t truncation
fits in the ip payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detected while fuzzing it through sequence (single packets, multiple, and more mutations).