More various fixes (F-*)#116
Open
gasbytes wants to merge 6 commits into
Open
Conversation
Contributor
gasbytes
commented
May 12, 2026
gasbytes
commented
- a1bbd16 added missing testing coverage that injects a non-first fragment and asserts the datagram is dropped
- f8fd06d validate opt[1] against remainign options space
- dd4f97e added checks to prevent null pointer deference wolfip_sock_* mirroring the fix applied to wolfip_sock_socket
- eaae38e hoist the lsrr/ssrr drop check above the forwarding branch so source-routed packets are dropped on both paths per RFC 7126 section 3.8
- 710ec42 populate last_pkt_ttl (time to live of the last packet) mirroring the same behaviour that we for for icmp/raw sockets to cover all accepted segments/fragments
- 4e2060b drop double byte-swap ip id field
same behaviour that we for for icmp/raw sockets to cover all accepted segments/fragments
…routed packets are dropped on both paths per RFC 7126 section 3.8
mirroring the fix applied to wolfip_sock_socket
…asserts the datagram is dropped
gasbytes
force-pushed
the
2026-05-11-findings-fixes
branch
from
a1bbd16 to
d6ef59d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.