Open
Conversation
…PM2 commands. Combined some duplicate code.
embhorn
reviewed
Jan 7, 2026
Member
embhorn
left a comment
embhorn
left a comment
There was a problem hiding this comment.
Just a few minor questions...
| } | ||
|
|
||
| #ifndef WOLFTPM_NO_PCR_POLICY | ||
| if (endorseKey) { |
Member
There was a problem hiding this comment.
if endorseKey is set, should this be an error?
Member
There was a problem hiding this comment.
With ./configure --enable-devtpm --enable-debug --disable-pcr-policy
./examples/keygen/keygen -eh
TPM2.0 Key generation example
Key Blob: keyblob.bin
Algorithm: RSA
Template: AIK
SRK: RSA
Use Parameter Encryption: NULL
TPM2: Caps 0x00000000, Did 0x0000, Vid 0x0000, Rid 0x 0
TPM2_CreatePrimary: 0x80000000 (314 bytes)
RSA AIK template
Creating new RSA key...
TPM2_Create key failed 303: TPM_RC_AUTH_UNAVAILABLE: The authValue or authPolicy is not available for selected entity
wolfTPM2_CreateKey failed
Failure 0x12f: TPM_RC_AUTH_UNAVAILABLE: The authValue or authPolicy is not available for selected entity
TPM2_FlushContext: Closed handle 0x80000000
| list(APPEND WOLFTPM_DEFINITIONS | ||
| "-DWOLFTPM_NO_ATTESTATION") | ||
| endif() | ||
|
|
Member
There was a problem hiding this comment.
Does it make sense to add conditions to the examples build section, as is done with the include.am instructions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Command Group Options for Code Size Reduction
Adds compile-time options to exclude groups of TPM2 commands, reducing code size for bare-metal and safety-critical applications.
New Build Options
WOLFTPM_NO_NV--disable-nvWOLFTPM_NO_PCR_POLICY--disable-pcr-policyWOLFTPM_NO_ATTESTATION--disable-attestationAll options default to enabled for backward compatibility.