rsa key validation test and additions to rsa fromdata test#339
Open
sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
Open
rsa key validation test and additions to rsa fromdata test#339sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
sebastian-carpenter wants to merge 1 commit intowolfSSL:masterfrom
Conversation
18111bf to
e39224b
Compare
SparkiDev
reviewed
Jan 7, 2026
| } | ||
|
|
||
| if (ok) { | ||
| for(prime = 0; prime < VALIDATE_PRIMES_SIZE; prime++) { |
Contributor
There was a problem hiding this comment.
Can you not use mp_prime_is_prime() with 0 trials?
Contributor
Author
There was a problem hiding this comment.
That would fail before it tests primes because you can't have 0 trials (as far as I know).
OpenSSL does 5 rounds of miller-rabin anyway so I'd like to use mp_prime_is_prime() but I get different results between OpenSSL and wolfProvider.
6dd7067 to
982f4fd
Compare
ColtonWilley
previously approved these changes
Feb 2, 2026
updated rsa_key_import / validate to survive new tests
982f4fd to
b518965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding tests for rsa key validation as well as adding some more cases to the rsa fromdata test.
Bugs:
Additions (these are bugs too though):
Problems?