add macro guard on SHA512 hashType#357
Draft
JacobBarthelmeh wants to merge 1 commit intowolfSSL:mainfrom
Draft
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #357
Scan targets checked: wolfhsm-crypto-bugs, wolfhsm-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves compatibility with wolfSSL builds where SHA-512 is enabled but wc_Sha512 does not include the hashType member (WOLFSSL_SHA512_HASHTYPE is not defined), by adding compile-time guards and extending CI to cover that configuration.
Changes:
- Guard SHA-512 async/DMA test helpers and their invocation behind
WOLFSSL_SHA512_HASHTYPE. - Guard the server-side DMA SHA-512 resume-state assignment to
sha512->hashTypebehindWOLFSSL_SHA512_HASHTYPE. - Add a
NO_SHA512_HASHTYPE=1test build mode and a CI job to build/run with that configuration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
test/wh_test_crypto.c |
Avoids compiling/calling SHA-512 async/DMA tests when WOLFSSL_SHA512_HASHTYPE is not available. |
test/Makefile |
Adds NO_SHA512_HASHTYPE=1 build option to disable WOLFSSL_SHA512_HASHTYPE via test user settings. |
test/config/user_settings.h |
Makes WOLFSSL_SHA512_HASHTYPE conditional on WHTEST_NO_SHA512_HASHTYPE. |
src/wh_server_crypto.c |
Avoids referencing wc_Sha512.hashType when the member is not present. |
.github/workflows/build-and-test.yml |
Adds CI coverage for DMA builds with SHA-512 enabled but WOLFSSL_SHA512_HASHTYPE disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.