Fix potential DMA buffer handling errors #284
Merged
+22
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For DMA buffer cleanup using wh_Client_DmaProcessClientAddress(), the size of the buffer is required. In many places, the size stored in the request message is used during the cleanup call. However, the request is overwritten when reading the response from the server, potentially overwriting the stored size parameters. When the size passed to the cleanup is incorrectly overwritten with zero, the method is exited early, potentially causing a memory leak.
bigbrett
approved these changes
Feb 10, 2026
AlexLanzano
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DMA buffer cleanup using
wh_Client_DmaProcessClientAddress(), the size of the buffer is required. In many places on the client side, the size stored in the request message is used during the cleanup call. However, the request is overwritten when reading the response from the server (as they share the underlying buffer), potentially overwriting the stored size parameters. When the size passed to the cleanup is incorrectly overwritten with zero, the cleanup method is exited early, potentially causing a memory leak.This problem has been identified while reworking the AES DMA operations for #282.