This repository was archived by the owner on Jan 26, 2019. It is now read-only.
Allowing GlobalSetup and GlobalTeardown for Jest testing.#412
Open
Brian-McBride wants to merge 8 commits intowmonk:masterfrom
Brian-McBride:master
Open
Allowing GlobalSetup and GlobalTeardown for Jest testing.#412Brian-McBride wants to merge 8 commits intowmonk:masterfrom Brian-McBride:master
Brian-McBride wants to merge 8 commits intowmonk:masterfrom
Brian-McBride:master
Conversation
Allowing users to define Jest GlobalSetup and GlobalTeardown for testing.
Adding in GlobalSetup and GlobalTeardown keys
Updating packages here and there as source repo is a bit behind.
Reducing changes for now
Accidently simplified too far last commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my unit and integration tests, I really needed to leverage the newish feature in Jest
GlobalSetupandGlobalTeardown.It looks like Dan will add it to create-react-app. It's really just adding the passthrough keys. However, this script needs updated
jestandts-jestpackages. Which also lead to some minor fixes prompted byts-jest.facebook/create-react-app#4393 (comment)
Then, well, I saw a few really old npm package versions and bumped them, testing with a fresh create-react-app. My
build,start, andtestcommands all work as expected in this Pull Request. Plus, I gain the ability to now setup and teardown global settings properly around unit/integration testing.