ADS1115 v2: skip ADC loop during strip updates, bump deps and improve docs#5655
Conversation
WalkthroughThis PR updates the ADS1115_v2 usermod with refactored loop control logic using early-return guards, upgraded Adafruit library dependencies, and comprehensive documentation rewrite describing v2 features and configuration options. ChangesADS1115_v2 Usermod Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@usermods/ADS1115_v2/readme.md`:
- Line 25: Update the installation instruction that currently tells users to add
"ADS1115" to custom_usermods in platformio.ini: change that string to the
correct module key "ADS1115_v2" (or explicitly note if the key is intentionally
different) so the README's add-to-custom_usermods instruction matches the
directory/module name; verify the README text near the
custom_usermods/platformio.ini mention and replace "ADS1115" with "ADS1115_v2".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 68f92cbd-ac0c-422d-8a28-7f295ef4ed75
📒 Files selected for processing (3)
usermods/ADS1115_v2/ADS1115_v2.cppusermods/ADS1115_v2/library.jsonusermods/ADS1115_v2/readme.md
|
thanks for the upate. |
This PR refactors the ADS1115 usermod loop to avoid running ADC processing while LED output is actively updating.
What changed
strip.isUpdatingin the ADS1115 loop.Why
Validation:
Summary by CodeRabbit
ADS1115 v2 Usermod Update
Bug Fixes
Documentation
Chores