Add DirBrowseFlags to IisWebDirProperties#596
Add DirBrowseFlags to IisWebDirProperties#596bevanweiss wants to merge 3 commits intowixtoolset:mainfrom
Conversation
|
I think it might be better to rename the Db column as a more generic 'Attributes' field, since this provides some additional bits for flags for future enhancement with other boolean settings (would have been useful if this was already in so I could have used some for these browse flags). I think there is a test case for a 'bug' in here also (commented out). will crash out database validation since the 2147483648 value == 0x80000000 the MSI_NULL_INTEGER...
Since this column addition will break the merge module back compatibility (as I understand), it should probably be coupled with some other changes to IIS schema also (ScriptTimeout I think was the other) |
b5de212 to
f181445
Compare
c856313 to
13c28fa
Compare
98bf1e7 to
ab91d51
Compare
|
This PR doesn't have the changes indicated around the Script timeouts. |
generic usage for other flags in future) Fixes wixtoolset/issues#170 Fixes wixtoolset/issues#2637 Fixes wixtoolset/issues#2917 Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
MSI_NULL_INTEGER value Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
Just checks that they don't throw errors, no actual verification yet. Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
ab91d51 to
423f4a2
Compare
adeb395 to
cd5f73d
Compare
|
I can possibly update this PR (this weekend) to the point where it could be merged in (without the Script timeout item) if there's value in that? |
Adds in support for configuring IIS DirBrowseFlags to Web Directories.
Fixes wixtoolset/issues#170
Fixes wixtoolset/issues#2637
Fixes wixtoolset/issues#2917