Skip to content

Enable prop overrides for SearchInput #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adids1221 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Enable prop overrides for SearchInput #3917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/react-native-ui-lib/src/components/searchInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const SearchInput = forwardRef((props: SearchInputProps, ref: ForwardedRef<any>)
value: controlledValue,
onChangeText,
onClear,
containerStyle,
customRightElement,
style,
inaccessible
Expand Down Expand Up @@ -101,7 +100,6 @@ const SearchInput = forwardRef((props: SearchInputProps, ref: ForwardedRef<any>)
};

const onChangeTextHandler = (text: string) => {
console.log(`onChangeTextHandler, text:`, text);
onChangeText?.(text);
setValue(text);
setHasValue(!_.isEmpty(text));
Expand Down Expand Up @@ -153,27 +151,28 @@ const SearchInput = forwardRef((props: SearchInputProps, ref: ForwardedRef<any>)
color={invertColors ? INVERTED_TEXT_COLOR : undefined}
$textDefault
text65M
{...cancelButtonProps}
onPress={onDismiss}
testID={`${testID}.cancelButton`}
{...cancelButtonProps}
/>
);
}
};

const renderTextInput = () => {
const {placeholder} = props;
const {containerStyle, ...others} = props;
const height = getHeight();
const placeholderTextColor = invertColors ? INVERTED_TEXT_COLOR : Colors.$textDefault;
const selectionColor = invertColors ? INVERTED_TEXT_COLOR : Colors.$textDefault;
return (
<View style={[styles.inputContainer, {height}]}>
<TextInput
accessibilityRole={'search'}
placeholder={placeholder}
placeholder={others.placeholder}
placeholderTextColor={placeholderTextColor}
underlineColorAndroid="transparent"
selectionColor={selectionColor}
{...others}
ref={searchInputRef}
value={value}
allowFontScaling={false}
Expand Down
4 changes: 3 additions & 1 deletion packages/react-native-ui-lib/src/components/searchInput/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export interface SearchInputRef {
focus: () => void;
}

export type SearchInputProps = TextInputProps & {
export type SearchInputSpecificProps = {
/**
* On clear button callback.
*/
Expand Down Expand Up @@ -66,3 +66,5 @@ export type SearchInputProps = TextInputProps & {
*/
preset?: SearchInputPresets | `${SearchInputPresets}`;
};

export type SearchInputProps = Omit<TextInputProps, 'style' | 'ref'> & SearchInputSpecificProps;