fix: prevent ExpandableOverlay onDismiss callback from being called twice #3916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the
onDismisscallback passed viamodalPropsordialogPropswas being called twice when the overlay was dismissed.The issue occurred because
closeExpandablewas being triggered from multiple sources:onBackgroundPress/onRequestClosewhen user dismissed the modalonDismisscallbackAdded a new
dismissOverlayfunction that only closes the UI without calling the user's callback. Modal'sonDismissnow usesdismissOverlay, whileonBackgroundPressandonRequestClosecontinue to usecloseExpandable.Verified that components using ExpandableOverlay are not affected:
Changelog
ExpandableOverlay - Fixed
onDismisscallback being called twice when modal is dismissed.Additional info
MADS-4656
Old PR (Closed because of conflicts, all the comments there are fixed here)