-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Edge2edge android #8262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
markdevocht
wants to merge
36
commits into
master
Choose a base branch
from
feat/edge2edge-android
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Edge2edge android #8262
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
4162390
Apply color animations on tab-switching (Android-only) (#7975)
d4vidi 9205aa0
Update package.json version to 7.44.0 [buildkite skip]
mobileoss 749936c
Fix npm registry and recreate package-lock.json (#7987)
d4vidi a9a2e8e
fix(sdk35): Apply inset over bottom-tabs (#7991)
d4vidi 9121357
Update package.json version to 7.45.0 [buildkite skip]
mobileoss 4509824
Revert "Feat/rn76 oldarch (#7967)" (#8003)
d4vidi 9b84952
Update package.json version to 7.46.0 [buildkite skip]
mobileoss 1ee3747
Mocked side-menus - support (#8017)
d4vidi d3d6961
Update package.json version to 7.47.0 [buildkite skip]
mobileoss 0bdfb20
Support drawer menus opening as overlay instead of pushing content in…
liatnetach a3a05d5
Update package.json version to 7.48.0 [buildkite skip]
mobileoss b38690d
Patch-fix some recent side-menu overlay mode changes (#8039)
d4vidi 06195fd
Introduce options to make a floating bottom-tabs (Android) (#8064)
d4vidi ab1a697
Update package.json version to 7.49.0 [buildkite skip]
mobileoss 18db32e
fix: top bar buttons disappeared when lock screen then unlock sreen (…
gosha212 37717da
Update package.json version to 7.50.0 [buildkite skip]
mobileoss 2257ec8
Back-compat edge2edge for standard layout, incl. drawBehind
d4vidi 6f66d03
merge master into me
markdevocht 04d5371
first config to get it running
markdevocht b3ee6c1
bottom bar edge2edge complete?
markdevocht f0a8c75
statusbar e2e
markdevocht 730eabb
cleanup
markdevocht 57681c9
backward compatiblility
markdevocht 5ea1125
final touches
markdevocht e0ac2db
Merge remote-tracking branch 'origin/master' into feat/edge2edge-android
markdevocht e4a6cbd
Fix yarn registry to use public npmjs.org instead of internal wixpress
markdevocht 88bb092
https://github.com/wix/react-native-navigation/issues/8080
markdevocht 0e13a7b
conflict fixes
markdevocht 8350ea4
snapshot updates
markdevocht 8d5f259
more updates
markdevocht 505ae42
Merge remote-tracking branch 'origin/master' into feat/edge2edge-android
markdevocht 7e868ff
update e2e android
markdevocht 9476ae2
snapsot update
markdevocht 04f3328
documentation
markdevocht 64d3d82
added
markdevocht 97e04dd
codex fixes
markdevocht File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new internal edge-to-edge flag is only set in the default
NavigationActivity.enableEdgeToEdge()implementation viaSystemUiUtils.activateEdgeToEdge(). If an app overridesenableEdgeToEdge()and callsEdgeToEdge.enable(this)itself, the override never reaches that helper, soComponentViewControllerstill treats edge-to-edge as inactive and skips forwarding nav-bar insets toSafeAreaView, while nav-bar colors continue going through the non-edge-to-edge path. That is also the exact override pattern documented in the new guide, so custom adopters of this API will get partially broken edge-to-edge behavior unless they know to call an extra internal helper.