fix: drain binding test child stdio#613
Open
roblandry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipeOutputOnNodeis enabledWhy
In an OpenClaw Debian 12 container with Intel Vulkan libraries installed, the Vulkan prebuilt addon can be imported directly and the GPU support check passes when the binding test child process uses piped stdio.
With the current default
stdio: ["ignore", "ignore", "ignore", "ipc"], the child exits before sending its initialreadyIPC message, causinggetLlama()to skip otherwise-working prebuilt binaries and fall back to building from source.Piping and draining stdio in the parent avoids attaching the child to ignored/null fds while still discarding output by default.
Validation
npm run test:typescriptnpm run lint:eslint -- src/bindings/utils/testBindingBinary.ts