Conversation
…pile with gcc-4.7 - fixes issue wisec#7
|
Thanks Dmitry, Also I have some comment that I'll add to the code. |
|
sorry there were more changes that necessary - thanks for double-checking (I'm glad I used a PR :) ) I reverted the lines that you commented on. See if you can use it now! I verified that after reversion it compiles on Fedora (x86_64) and on Ubuntu 12 LTS (32-bit). |
|
hehe you're right! |
|
I see that conditional compilation guards need to be added around #include <unistd.h> lines - what is the typical or recommended style? #ifdef linux ? |
|
have a look at : this is one of the patches for the missing inclusion of unistd issue. |
|
OK - copied the guards from the mozilla-central file, should be good now. Sorry for bunch of commits! Compiles on Fedora but I did not try it on Windows yet. |
|
Confirmed that my repository https://github.com/dmitris/DOMinator builds fine on Windows (with MozillaBuild and pymake), tests run fine, Firefox application opens. The PR should be now fine to merge - let me know if you see any remaining problems with it. Thanks. |
...e with gcc-4.7 - fixes issue #7
(Compiled on Fedora 17 x86-64, need to verify that it still compiles on Ubuntu/Debian)