Support key param for sortBy and sortByDescending#33
Open
couzic wants to merge 3 commits intowinterbe:masterfrom
Open
Support key param for sortBy and sortByDescending#33couzic wants to merge 3 commits intowinterbe:masterfrom
couzic wants to merge 3 commits intowinterbe:masterfrom
Conversation
Contributor
Author
|
Hello @winterbe, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is possible to sort using the key of an item, but only through the
ComparatorandComparatorFactoryinterfaces, for example:sequency/test/sorted.test.ts
Line 67 in 7be941d
sequency/test/sorted.test.ts
Line 89 in 7be941d
sequency/test/sorted.test.ts
Line 108 in 7be941d
sequency/test/sorted.test.ts
Line 135 in 7be941d
The goal of this PR is to enable sorting by key directly on the
Sequencetype, like:Also, this PR exports the
ComparatorandComparatorFactorytypes, so that they are added to the docs (which suppresses a couple warnings when generating them)