-
Notifications
You must be signed in to change notification settings - Fork 53
Remove raw requirements references and point to workspace dependencies #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying windmilldocs with
|
| Latest commit: |
c006585
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07586598.windmilldocs.pages.dev |
| Branch Preview URL: | https://claude-issue-1186-20251215-1.windmilldocs.pages.dev |
|
/ai you missed a whole lot of information to remove: Although Windmill can automatically resolve imports. It is possible to override the dependencies by providing a requirements.txt file in the same directory as the script as you would do in a standard Python project, building and maintaining a requirements.txt to declare dependencies. remove all of it. Second do not remove migration guide.
|
|
Claude finished @pyranota's task —— View job ✅ CompletedSuccessfully removed all references to
The documentation now focuses on workspace dependencies, standard import inference, and PEP-723 inline metadata as the primary methods for dependency management. |
|
/ai DO NOT REMOVE DocCards. DO NOT REMOVE MIGRATION GUIDE |
|
Claude finished @pyranota's task —— View job ✅ Verification CompleteAll requested elements have been properly preserved in the PR: DocCards preserved:
Migration guide preserved:
Requirements.txt references removed:
The changes correctly remove outdated |
pyranota
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ai address the review
|
Claude finished @claude[bot]'s task —— View job ✅ Review comments addressedTodo List:
Changes Made:
The review comments have been addressed - all DocCards that should be preserved are now in place, while the requirements.txt documentation remains removed as per the original PR objective. |
326e551 to
ad6f49f
Compare
bc7c8ec to
c006585
Compare
hcourdent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have a mention of '#lockfile-per-script-inferred-from-a-requirementstxt' on the Imports page
Also, should 6_imports/dependency_management.png be updated now?
Summary
Removes references to the outdated "raw requirements" system and points users to the new workspace dependencies system instead.
Changes
Notes
There was no dedicated "raw requirements" documentation section to remove. The only mentions were in the workspace dependencies docs themselves. The migration guide was kept intentionally since it helps users transition from the old system.
Fixes #1186
Generated with Claude Code