Raise a warning if there are nan values in the weather data set #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com:wind-python/windpowerlib into features/add_warning_if_nan_values_in_weather_data
Member
Author
|
@woutertP1 Please check if this warning would has helped you. @SabineHaas , @birgits What do you think? |
SabineHaas
approved these changes
Jan 21, 2020
Member
SabineHaas
left a comment
SabineHaas
left a comment
There was a problem hiding this comment.
I wasn't aware of this problem. Thanks for opening the issue @woutertP1 and thanks for implementing @uvchik!
uvchik
deleted the
features/add_warning_if_nan_values_in_weather_data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95.
Changes proposed in this pull request:
If there are nan values in the weather data a warning will raised. The message includes which columns contain nan values.
I moved the tests to the tools module, because the code would be duplicate (
ModelChainandTurbineClusterModelChain)I can add tests if you agree with this approach.
[ ] add tests