Fix turbine #92
Merged
Fix turbine #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uvchik
reviewed
Jan 7, 2020
Member
uvchik
left a comment
uvchik
left a comment
There was a problem hiding this comment.
I think it is a good idea to filter wrong parameter combinations. Thank you.
Just two small comments.
| if self.rotor_diameter: | ||
| if self.hub_height <= 0.5*self.rotor_diameter: | ||
| msg = "1/2*rotor_diameter cannot be higher than hub_height" | ||
| raise ValueError(msg) |
Member
There was a problem hiding this comment.
I am not a native speaker but as I know it in a mathematical sense one value is GREATER than another not HIGHER.
| 'path': self.source | ||
| } | ||
| with pytest.raises(ValueError): | ||
| WindTurbine(**char) |
Member
There was a problem hiding this comment.
I would use the match attribute to make sure the right ValueError is raised.
with pytest.raises(ValueError, match=regex)
Contributor
Author
There was a problem hiding this comment.
Implemented. However, I had a problem with match when there was an asterisk symbol in the string so I modified the error message slightly.
uvchik
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89 .