-
Notifications
You must be signed in to change notification settings - Fork 111
Add stickler and black config files #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@uvchik If this gets merged and the contributors are supposed to run Black before submitting a PR than adding information in "Contributing" reflecting this should be needed? Also adding it now seems OK. |
|
If it works as intended you do not have to run Black before submitting a PR. At the moment you have to follow the pep rules anyway. Stickler-ci will check that and Black may fix it automatically but at the moment it does not seem to work. Maybe I have to merge it to get it work. |
|
Now it works. According to @gnn the black style might not be "everybody's darling" but is well documented and every decision is explained in the black documentation. I personally do not like everything but as it makes things easier I would vote for using it. |
|
Thanks for implementing this @uvchik! Anyways, I really appreciate that we then have a consistent style (no matter the brackets ;)) |
I do not like them either 😏 But I would not change it, because of two reasons.
I would like both of you (@birgits, @SabineHaas) to approve this issue. @vezeli already reacted with the 👍 emoji. |
SabineHaas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot :)
birgits
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @uvchik for implementing this!
Fixes #81 .
Test stickler-ci for the windpowerlib.