Fixes/#73 revise notebooks #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indpowerlib into fixes/#73_revise_notebooks
uvchik
requested changes
May 11, 2020
Member
uvchik
left a comment
uvchik
left a comment
There was a problem hiding this comment.
If the output has changed we should know why. Do you know it?
Comment on lines
24
to
26
| assert_allclose( | ||
| 2764.194772, (e126.power_output.sum() / e126.nominal_power), 0.01 | ||
| 2730.142, (e126.power_output.sum() / e126.nominal_power), 0.01 | ||
| ) |
Member
There was a problem hiding this comment.
Are you sure that the new value is correct? Why is the old value wrong?
Member
Author
There was a problem hiding this comment.
Yes, it's because I changed the power_output_model to "power_coefficient_curve". And I changed the power output model because I wanted one example showing how to use the power coefficient curve. At an earlier point the power coefficient curve was used when calculating the feed-in for my_turbine2, but we now only provide its power curve.
uvchik
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73.
Thanks @uvchik for adding a download for the weather data file and adapting the python scripts. This PR adapts the jupyter notebooks, deletes the now obsolete dummy turbine data files and adapts the README accordingly.