Keep a stack of continuations when shrinking#98
Open
obrok wants to merge 1 commit intowhatyouhide:mainfrom
Open
Keep a stack of continuations when shrinking#98obrok wants to merge 1 commit intowhatyouhide:mainfrom
obrok wants to merge 1 commit intowhatyouhide:mainfrom
Conversation
Owner
|
Hey @obrok, any particular reason for closing this? |
Contributor
Author
|
I was mostly cleaning up my PR list on github of very old PRs. If you think this has value, you can reopen, but I'm no longer working on the project where I had this problem, so, most likely, I won't be able to do any changes or otherwise help out with this. |
Owner
|
Hey @obrok, thanks for clearing this up. If you don't mind, I'll keep this open a bit more hoping to have some cycles to work on StreamData. Thank you, and sorry for the long wait! 💟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
I dug around some more and managed to come up with the following change to fix #97. It doesn't seem to help with deeply nested cases of
tree/2, but seems to work in the basic cases. I'm a bit unsure of this, because there aren't many tests of shrinking. Let me know what you think.