websocket-client compatibility fix #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhuanchen
reviewed
Nov 3, 2018
Contributor
junhuanchen
left a comment
junhuanchen
left a comment
There was a problem hiding this comment.
good changed.
To solve the higher version is the problem.
because 0.37 is my used.
try it, thanks~
Collaborator
|
Why the log level changes here? |
| def __del__(self): | ||
| self.close() | ||
|
|
||
| def on_message(self, ws, message): |
Collaborator
There was a problem hiding this comment.
The websocket-client README indicates that this argument is still used, why the discrepancy?
Collaborator
There was a problem hiding this comment.
It seems that they do, indeed, pass two arguments. Which version have you tested your code with?
Author
Why not? It's a different commit in the same pull request. What's wrong with it? |
Collaborator
I'm just wondering what your motivation is for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.