Open
Conversation
macOS caps OpenGL at 4.1 via Metal translation, so GL 4.3/4.4 features (persistent mapped buffers, multi-draw-indirect, vertex attrib binding) are unavailable. This adds ifdef-guarded fallbacks for macOS while keeping the fast path for Linux. - Makefile: detect Darwin, use clang++, -framework OpenGL, homebrew paths - vertexpool.h: GL 4.1 fallbacks behind TINYENGINE_OS_MAC - Shaders: GLSL 430 -> 410 (subset-compatible, no effect on Linux) - SimpleHydrology.cpp: fix UB in version assert (strcmp vs == on char[]) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
tested on Mac! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#ifndef TINYENGINE_OS_MACguards — Linux builds are unchangedChanges
uname, sets clang++,-framework OpenGL, homebrew paths,-DTINYENGINE_OS_MAC#ifdef TINYENGINE_OS_MACfallbacks for:glVertexAttribPointerinstead ofglVertexAttribFormat/glBindVertexBuffer(GL 4.3)glBufferData+ CPU buffer instead ofglBufferStorage+ persistent mapping (GL 4.4)glDrawElementsBaseVertexloop instead ofglMultiDrawElementsIndirect(GL 4.3)#version 430 core→#version 410 core, removedconston local vars (Apple GLSL rejects this)strcmpinstead of==onchar[])Prerequisites
TinyEngine must also be compiled with
-DTINYENGINE_OS_MACon macOS (its Makefile examples already do this).Test plan
TINYENGINE_OS_MACdefined → original GL 4.3 path)make all🤖 Generated with Claude Code