[docs] silk to pcm and wav#340
Open
iftaken wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=======================================
Coverage 41.50% 41.50%
=======================================
Files 27 27
Lines 1930 1930
=======================================
Hits 801 801
Misses 1129 1129
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for your contribution and improvement, can you add some description about what you have done in this pr, so that other developers can get it quickly. |
wj-Mcat
approved these changes
Jul 5, 2022
wj-Mcat
left a comment
wj-Mcat
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
You have udpated the solution for transformation between silk and wav file. Thanks for your contribution.
Collaborator
|
The final process, you should sign the cla license so that I can merge the pr. |
Collaborator
Wechaty Contributors NominationLink to wechaty/PMC#16 |
Collaborator
|
@iftaken please fix the conflicts. |
Collaborator
|
ping @iftaken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in pysilk converting silk to wav, it is recommended to use pilk, first convert silk to pcm, and then use ffmepg to convert to wav format