Enhancement: Add fallback for missing SVG Rendering in SplashViz.jsx#8002
Closed
rahul-kr-rai wants to merge 1 commit intowebpack:mainfrom
Closed
Enhancement: Add fallback for missing SVG Rendering in SplashViz.jsx#8002rahul-kr-rai wants to merge 1 commit intowebpack:mainfrom
rahul-kr-rai wants to merge 1 commit intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexander-akait
requested changes
Mar 13, 2026
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Is it possible when we don't have it? No need to make something if it will not happen
Contributor
Author
|
Fair point! Since it's a static import, the build process would catch any missing assets anyway. I'll revert this to keep the code lean. |
Member
|
Let's close because we don't need it, we can revisit this in future if we will have situations when we don't have content |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds null/undefined checks with a fallback message for SVG rendering in the
SplashViz.jsxcomponent. It ensures that ifHomeSVG.bodyis missing, the component will not break and instead display a clear fallback.What kind of change does this PR introduce?
Enhancement: improves resilience and user feedback in case of missing SVG data.
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI
GitHub Copilot